Replace all &DiagCtxt with a DiagCtxtHandle<'_> wrapper type
#126623
Conversation
rustbot
added
A-query-system
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri
cc @davidtwco, @compiler-errors, @TaKO8Ki Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
oli-obk
changed the title
&DiagCtxt with a DiagCtxtHandle<'_> wrapper type
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
do_not_count_errors
branch
from
9fcb89e
to
001f154
Compare
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in match checking cc @Nadrieril |
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #126049) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
do_not_count_errors
branch
from
001f154
to
d3799de
Compare
|
r=me once CI passes |
This comment has been minimized.
This comment has been minimized.
This paves the way for tracking more state (e.g. error tainting) in the diagnostic context handle
oli-obk
force-pushed
the
do_not_count_errors
branch
from
d3799de
to
3f34196
Compare
|
@bors r=davidtwco p=1 bitrotty |
bors
added
S-waiting-on-bors
|
@bors p=5 (very bitrotty) |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (dd104ef): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.639s -> 671.341s (-0.04%) |
Related change:
- rust-lang/rust#126623
Related change:
- rust-lang/rust#126623
Resolves #3275
…piler-errors Split the lifetimes of `MirBorrowckCtxt` These lifetimes are sometimes too general and will link things together that are independent. These are a blocker for actually finishing tracking more state (e.g. error tainting) in the diagnostic context handle, and I'd rather land it in its own PR instead of together with functional changes. Also changes a bunch of named lifetimes to `'_` where they were irrelevant follow-up to rust-lang#126623
Rollup merge of rust-lang#126911 - oli-obk:do_not_count_errors, r=compiler-errors Split the lifetimes of `MirBorrowckCtxt` These lifetimes are sometimes too general and will link things together that are independent. These are a blocker for actually finishing tracking more state (e.g. error tainting) in the diagnostic context handle, and I'd rather land it in its own PR instead of together with functional changes. Also changes a bunch of named lifetimes to `'_` where they were irrelevant follow-up to rust-lang#126623
r? @davidtwco
This paves the way for tracking more state (e.g. error tainting) in the diagnostic context handle
Basically I will add a field to the
DiagCtxtHandlethat refers back to theInferCtxt's (and others)Option<ErrorHandled>, allowing us to immediately taint these contexts when emitting an error and not needing manual tainting anymore (which is easy to forget and we don't do in general anyway)