Rollup of 5 pull requests #126630
Merged
Rollup of 5 pull requests #126630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set, this flag skips the code that normally extracts coverage spans from MIR statements and terminators. That sometimes makes it easier to debug branch coverage and MC/DC coverage, because the coverage output is less noisy. For internal debugging only. If other code changes would make it hard to keep supporting this flag, remove it.
This test reflects the current implementation behaviour, which is not necessarily the desired behaviour.
…tions These tests reflect the current implementation behaviour, which is not necessarily the desired behaviour.
…ed, r=jieyouxu Migrate `run-make/used` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`
… r=jieyouxu Migrate `error-found-staticlib-instead-crate`, `output-filename-conflicts-with-directory`, `output-filename-overwrites-input`, `native-link-modifier-verbatim-rustc` and `native-link-verbatim-linker` `run-make` tests to `rmake.rs` format Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
interpret: better error when we ran out of memory
coverage: Add debugging flag `-Zcoverage-options=no-mir-spans` When set, this flag skips the code that normally extracts coverage spans from MIR statements and terminators. That sometimes makes it easier to debug branch coverage and MC/DC coverage instrumentation, because the coverage output is less noisy. For internal debugging only. If future code changes would make it hard to keep supporting this flag, it should be removed at that time. `@rustbot` label +A-code-coverage
…rochenkov More thorough status-quo tests for `#[coverage(..)]` In light of the stabilization push at rust-lang#84605 (comment), I have written some tests to more thoroughly capture the current behaviour of the `#[coverage(..)]` attribute. These tests aim to capture the *current* behaviour, which is not necessarily the desired behaviour. For example, some of the error message are not great, some things that perhaps ought to cause an error do not, and recursive coverage attributes have not been implemented yet. `@rustbot` label +A-code-coverage
rustbot
added
A-run-make
|
@bors r+ p=5 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: af3d1004c7 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (8814b92): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.294s -> 671.639s (0.05%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
run-make/usedtormake.rs#125988 (Migraterun-make/usedtormake.rs)error-found-staticlib-instead-crate,output-filename-conflicts-with-directory,output-filename-overwrites-input,native-link-modifier-verbatim-rustcandnative-link-verbatim-linkerrun-maketests tormake.rsformat #126500 (Migrateerror-found-staticlib-instead-crate,output-filename-conflicts-with-directory,output-filename-overwrites-input,native-link-modifier-verbatim-rustcandnative-link-verbatim-linkerrun-maketests tormake.rsformat)-Zcoverage-options=no-mir-spans#126587 (coverage: Add debugging flag-Zcoverage-options=no-mir-spans)#[coverage(..)]#126621 (More thorough status-quo tests for#[coverage(..)])r? @ghost
@rustbot modify labels: rollup
Create a similar rollup