Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #126912

Closed
wants to merge 21 commits into from

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    9f0c7f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Configuration menu
    Copy the full SHA
    d630f5d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    a264bff View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Configuration menu
    Copy the full SHA
    3f2f843 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. On short error format, append primary span label to message

    The `error-format=short` output only displays the path, error code and
    main error message all in the same line. We now add the primary span label
    as well after the error message, to provide more context.
    estebank committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    57a82e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Configuration menu
    Copy the full SHA
    594fa01 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    8cfd4b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    273447c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba5ec1f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ffb5f9 View commit details
    Browse the repository at this point in the history
  5. add @Kobzol to bootstrap team for triagebot

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    45261ff View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#124460 - long-long-float:show-notice-about-…

    …enum-with-debug, r=pnkfelix
    
    Show notice about  "never used" of Debug for enum
    
    Close rust-lang#123068
    
    If an ADT implements `Debug` trait and it is not used, the compiler says a note that indicates intentionally ignored during dead code analysis as [this note](https://github.com/rust-lang/rust/blob/2207179a591f5f252885a94ab014dafeb6e8e9e8/tests/ui/lint/dead-code/unused-variant.stderr#L9).
    However this node is not shown for variants that have fields in enum. This PR fixes to show the note.
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7a6e41b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125740 - RalfJung:transmute-size-check, r=o…

    …li-obk
    
    transmute size check: properly account for alignment
    
    Fixes another place where ZST alignment was ignored when checking whether something is a newtype. I wonder how many more of these there are...
    
    Fixes rust-lang#101084
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e78bfc3 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#126413 - matthiaskrgr:crshmsg, r=oli-obk

    compiletest: make the crash test error message abit more informative
    
    r?  ``@oli-obk``
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    68a8f7b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=p…

    …nkfelix
    
    Mark assoc tys live only if the corresponding trait is live
    
    r? ``@pnkfelix``
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5229a5d View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#126673 - oli-obk:dont_rely_on_err_reporting…

    …, r=compiler-errors
    
    Ensure we don't accidentally succeed when we want to report an error
    
    This also changes the `DefiningOpaqueTypes::No` to `Yes` without adding tests, as it is solely run on the error path to improve diagnostics. I was unable to provide a test that changes diagnostics, as all the tests I came up with ended up successfully constraining the opaque type and thus succeeding the coercion.
    
    r? ``@compiler-errors``
    
    cc rust-lang#116652
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b452fc4 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#126804 - estebank:short-error-primary-label…

    …, r=davidtwco
    
    On short error format, append primary span label to message
    
    The `error-format=short` output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    868e8e3 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#126868 - bvanjoi:fix-126764, r=davidtwco

    not use offset when there is not ends with brace
    
    Fixes rust-lang#126764
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2f8880d View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#126893 - dtolnay:prec, r=compiler-errors

    Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level
    
    I have been tangling with precedence as part of porting some pretty-printer improvements from syn back to rustc (related to parenthesization of closures, returns, and breaks by the AST pretty-printer).
    
    As far as I have been able to tell, there is no difference between the 2 different precedence levels that rustc identifies as `PREC_POSTFIX` (field access, square bracket index, question mark, method call) and `PREC_PAREN` (loops, if, paths, literals).
    
    There are a bunch of places that look at either `prec < PREC_POSTFIX` or `prec >= PREC_POSTFIX`. But there is nothing that needs to distinguish PREC_POSTFIX and PREC_PAREN from one another.
    
    https://github.com/rust-lang/rust/blob/d49994b060684af423339b55769439b2f444a7b9/compiler/rustc_ast/src/util/parser.rs#L236-L237
    
    https://github.com/rust-lang/rust/blob/d49994b060684af423339b55769439b2f444a7b9/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs#L2829
    
    https://github.com/rust-lang/rust/blob/d49994b060684af423339b55769439b2f444a7b9/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs#L1290
    
    In the interest of eliminating a distinction without a difference, this PR collapses these 2 levels down to 1.
    
    There is exactly 1 case where an expression with PREC_POSTFIX precedence needs to be parenthesized in a location that an expression with PREC_PAREN would not, and that's when the receiver of ExprKind::MethodCall is ExprKind::Field. `x.f()` means a different thing than `(x.f)()`. But this does not justify having separate precedence levels because this special case in the grammar is not governed by precedence. Field access does not have "lower precedence than" method call syntax &mdash; you can tell because if it did, then `x.f[0].f()` wouldn't be able to have its unparenthesized field access in the receiver of a method call. Because this Field/MethodCall special case is not governed by precedence, it already requires special handling and is not affected by eliminating the PREC_POSTFIX precedence level.
    
    https://github.com/rust-lang/rust/blob/d49994b060684af423339b55769439b2f444a7b9/compiler/rustc_ast_pretty/src/pprust/state/expr.rs#L217-L221
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a98970a View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#126899 - GrigorenkoPV:suggest-const-block, …

    …r=davidtwco
    
    Suggest inline const blocks for array initialization
    
    rust-lang#126894
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c9186aa View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#126909 - onur-ozkan:add-kobzol, r=matthiaskrgr

    add @Kobzol to bootstrap team for triagebot
    
    Welcome `@Kobzol` !
    matthiaskrgr committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0659ab6 View commit details
    Browse the repository at this point in the history