Add a test for #107975 #127003
Open
Add a test for #107975 #127003
+732
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
SparrowLii
reviewed
Jun 27, 2024
| #![feature(exposed_provenance)] | ||
|
|
||
| use std::ptr::addr_of; | ||
|
|
There was a problem hiding this comment.
We'd better add a comment describing the expected result
| assert_ne!(i, 0); | ||
| println!("{}", i); | ||
| assert_eq!(i, 0); | ||
| } |
There was a problem hiding this comment.
Maybe add some more scenarios like #107975 (comment), #107975 (comment), #107975 (comment) and #107975 (comment)
|
@rustbot author |
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The int is zero. But also not zero. This is so much fun.
This is a part of #105107.
Initially I was going to just rebase #108445, but quite a few things changed since then:
a ?= bfor Miscompilation: Equal pointers comparing as unequal #107975 anymore. Now you have toa-b ?= 0. This is what this PR does. As an additional flex, it show that three ways of converting a pointer to its address have this issue:as usize.expose_provenance().addr()As an aside, the naming for
addr_of!is quite unfortunate in context of provenance APIs. Becauseaddr_of!gives you a pointer, but what provenance APIs refer to as "address" is theusizevalue. Oh well.UPD1: GitHub is incapable of parsing #107975 in the PR name, so let's add it here.
Footnotes
UPD2: The other mcve does not work anymore either, saying "this behavior recently changed as a result of a bug fix; see tracking issue for "universe transition" #56105 for details." ↩