Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make language around ToOwned for BorrowedFd more precise #127077

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make language around ToOwned for BorrowedFd more precise #127077

wants to merge 2 commits into from

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Jun 28, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 28, 2024
@tbu-
Copy link
Contributor Author

tbu- commented Jun 28, 2024

I'm not so sure about the text in the paragraph about ToOwned. Maybe we could omit it entirely? The situation is not different from any other type not implementing ToOwned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tbu- @rustbot @workingjubilee