-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "miri: make sure we can find link_section statics even for the local crate" #127099
Conversation
@bors try |
Revert "miri: make sure we can find link_section statics even for the local crate" This PR reverts rust-lang#126938 as [requested by its author](rust-lang#127052 (comment)), to fix the rust-lang#127052 regression. r? ghost fixes rust-lang#127052 We should probably improve the [`used` rmake test(s)](https://github.com/rust-lang/rust/blob/57931e50409f9365791f7923a68f9ae1ec301c4c/tests/run-make/used/rmake.rs#L7) in the future, though this should do for now. (Opening as draft to run tests on a windows env) try-job: x86_64-msvc
Thank you for filing this revert + regression test! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lqd, r=me when this is done bors-trying so we can fix this
The test technically looks good on the
(and by now an old windows box I have has finished rebuilding LLVM -- to workaround the recent linking issues that other people currently also experience when building rustc -- so I also checked that the test does fail on master without the revert, no need for another try build 🚀). I'm not sure if And if this is indeed what caused CI to fail recently maybe we can bump the prio. |
The Miri subtree was changed cc @rust-lang/miri |
@bors p=25 because this problem broke a bunch of ci runs already |
☀️ Try build successful - checks-actions |
finallyyyyyyy 😴 @bors r=compiler-errors |
Tested on commit rust-lang/rust@9ed2ab3. Direct link to PR: <rust-lang/rust#127099> 🎉 reference on windows: test-fail → test-pass (cc @Havvy @ehuss @matthewjasper).
☀️ Test successful - checks-actions |
Finished benchmarking commit (9ed2ab3): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -1.7%, secondary 4.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 694.621s -> 695.135s (0.07%) |
// removed by the MSVC linker, causing linking errors. | ||
|
||
//@ build-pass: needs linking | ||
//@ only-msvc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why shouldn't we run this test on all targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specific issue doesn't exist elsewhere so it's less useful there: the existing tests already cover #[used]
features and targets more than this test. Of course, it wouldn't hurt. Feel free to change the directive to something you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, clearly the existing tests do not cover #[used]
in the binary, or my PR would not have landed.
thank you @lqd 🙇♂️ (sometimes I have to spell it out where a emoji is not enough) |
… r=lqd,ChrisDenton unreferenced-used-static: run test everywhere Follow-up to rust-lang#127099.
Rollup merge of rust-lang#127115 - RalfJung:unreferenced-used-static, r=lqd,ChrisDenton unreferenced-used-static: run test everywhere Follow-up to rust-lang#127099.
This PR reverts #126938 as requested by its author, to fix the #127052 regression.
Fixes #127052
We should probably improve the
used
rmake test(s) in the future, but this should do for now.