Improve run-make/output-type-permutations code and improve filename_not_in_denylist API
#127451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_not_in_denylist` API
rustbot
added
A-run-make
|
The run-make-support library was changed cc @jieyouxu This PR modifies cc @jieyouxu |
Kobzol
approved these changes
Jul 7, 2024
| @@ -296,7 +296,8 @@ pub fn not_contains<P: AsRef<Path>>(path: P, expected: &str) -> bool { | |||
| } | |||
|
|
|||
| /// Returns true if the filename at `path` is not in `expected`. | |||
| pub fn filename_not_in_denylist<P: AsRef<Path>>(path: P, expected: &[String]) -> bool { | |||
| pub fn filename_not_in_denylist<P: AsRef<Path>, V: AsRef<[String]>>(path: P, expected: V) -> bool { | |||
There was a problem hiding this comment.
I'm not sure if we need to stuff these generics everywhere, as it makes the compilation of each run-make test slightly slower. But if the function was already generic before, it doesn't really change anything, so should be fine here.
|
You can r=me once CI is green. |
|
@bors r=kobzol rollup |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Kobzol