Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debuginfo: Represent SIMD types as tuple structs instead of as fixed-size arrays #14224

Merged
merged 1 commit into from
May 17, 2014

Conversation

michaelwoerister
Copy link
Member

This is a small change that improves the DWARF description of SIMD types by exposing their type name to debuginfo.

@alexcrichton
Copy link
Member

Would it be possible to add a test for this as well? If not, r=me.

@alexcrichton
Copy link
Member

Or is this covered by debuginfo/simd.rs?

@michaelwoerister
Copy link
Member Author

Yes, it's covered by debuginfo/simd.rs. In GDB the output is the same as before. In LLDB, however, one can have a custom type summary because of this change.

bors added a commit that referenced this pull request May 17, 2014
This is a small change that improves the DWARF description of SIMD types by exposing their type name to debuginfo.
@bors bors closed this May 17, 2014
@bors bors merged commit 3fabb11 into rust-lang:master May 17, 2014
@michaelwoerister michaelwoerister deleted the simd-update branch July 9, 2014 07:50
lnicola pushed a commit to lnicola/rust that referenced this pull request Mar 13, 2023
…cal-crates, r=Veykril

feat: allow `generate_function` to generate in different local crate

Closes rust-lang#14224

This PR allows `generate_function` assist to generate in crates other than the current one. I took a step further from the original request and made it allow to generate in any local crates since it looked reasonable and IDE layer doesn't really know about packages.

(actually we have been checking which crate we're generating in only for methods and not for freestanding functions, so we were providing the assist for `std::foo$0()`; it's both feature and fix in a sense)

The first commit is a drive-by fix unrelated to the feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants