Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debuginfo: Unify DWARF representation of enum types #14486

Merged
merged 2 commits into from
May 29, 2014
Merged

debuginfo: Unify DWARF representation of enum types #14486

merged 2 commits into from
May 29, 2014

Commits on May 29, 2014

  1. debuginfo: Add documentation comments to debuginfo.rs 

    Conflicts:
	src/librustc/middle/trans/debuginfo.rs
    @michaelwoerister
    michaelwoerister committed May 29, 2014
    Configuration menu
    Copy the full SHA
    1380893 View commit details
    Browse the repository at this point in the history

  2. debuginfo: Make DWARF representation of enums uniform. 

    So far the DWARF information for enums was different
for regular enums, univariant enums, Option-like enums,
etc. Regular enums were encoded as unions of structs,
while the other variants were encoded as bare structs.

With the changes in this PR all enums are encoded as
unions so that debuggers can reconstruct if something
originally was a struct, a univariant enum, or an
Option-like enum. For the latter case, information
about the Null variant is encoded into the union field
name. This information can then be used by the
debugger to print a None value actually as None
instead of Some(0x0).
    @michaelwoerister
    michaelwoerister committed May 29, 2014
    5 Configuration menu
    Copy the full SHA
    eea329b View commit details
    Browse the repository at this point in the history