Fix #14915 #14920
Closed
Fix #14915 #14920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pcwalton r? |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…le-struct, r=Veykril Fix edits for `convert_named_struct_to_tuple_struct` Two fixes: - When replacing syntax nodes, macro files weren't taken into account. Edits were simply made for `node.syntax().text_range()`, which would be wrong range when `node` is inside a macro file. - We do ancestor node traversal for every struct name reference to find record expressions/patterns to edit, but we didn't verify that expressions/patterns do actually refer to the struct we're operating on. Best reviewed one commit at a time. Fixes rust-lang#13780 Fixes rust-lang#14927
tvallotton
pushed a commit
to tvallotton/rust
that referenced
this pull request
Dec 15, 2023
…ert_tuple_struct_to_named_struct/handle_refs_inside_macro_invocations, r=Veykril Fix incorrectly replacing references in macro invocation in "Convert to named struct" assist Fixes rust-lang#15630. Complements rust-lang#13647 (same assist but missed this one), rust-lang#14920 (inverse action assist).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.