Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to librustuv for low level networking #15604

Merged
merged 1 commit into from
Jul 15, 2014

Conversation

mrmonday
Copy link
Contributor

This pull request adds some necessary function definitions and types for doing low level networking with Rust.

@alexcrichton
Copy link
Member

In the past we've been growing hesitant about exposing more platform-specific functionality from liblibc as it's already a bit of a mess. The bindings for librustuv seem fine, but perhaps the liblibc changes could be relegated to the relevant library outside of the compiler?

@mrmonday
Copy link
Contributor Author

So as you might have guessed, this is the beginnings of refactoring the raw socket stuff that I had before in a way that doesn't require massive additions to the standard libraries. I have a follow up pull request which will require some subset of the additions to liblibc; I have a separate library which requires the rest.

Perhaps I could figure out what additions are necessary and change this pull request to only add them? Or would you rather I include the additions with my follow-up pull request and only add the librustuv things here?

@alexcrichton
Copy link
Member

The libuv changes for now and possibly more later sounds good to me!

 * Adds functions for using arbitrary sockets with libuv
 * Adds types and functions required to support this.
@mrmonday mrmonday changed the title Additions to liblibc and librustuv for low level networking Additions to librustuv for low level networking Jul 15, 2014
@mrmonday
Copy link
Contributor Author

I've updated this pull request to just have the librustuv changes - I will submit the liblibc changes alongside the other modifications later on.

bors added a commit that referenced this pull request Jul 15, 2014
This pull request adds some necessary function definitions and types for doing low level networking with Rust.
@bors bors closed this Jul 15, 2014
@bors bors merged commit e1fc3a6 into rust-lang:master Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants