Deprecate the url crate. #16076
Merged
Deprecate the url crate. #16076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis reports a tidy error: The relevant line testing an expected error message in a compile-fail test: //~^ ERROR use of deprecated item: This is being removed. Use rust-url instead. http://servo.github.io/rust-url/Is there a way to write the expected message (which is one line) in two source lines, or should I just chop it? (I believe the test harness checks that the actual error message starts with the expected, rather than equals.) |
|
Tests can be tagged with |
|
Fixed. |
The replacement is [rust-url](https://github.com/servo/rust-url), which can be used with Cargo. Fix rust-lang#15874 Fix rust-lang#10707 Close rust-lang#10706 Close rust-lang#10705 Close rust-lang#8486
|
Build failed with Pushed a squashed commit to add BTW, is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement is rust-url, which can be used with Cargo.
Fix #15874
Fix #10707
Close #10706
Close #10705
Close #8486