Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for in-place map for Vecs of types with same size #16369

Closed
wants to merge 4 commits into from
Closed

Add support for in-place map for Vecs of types with same size #16369

wants to merge 4 commits into from

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Aug 8, 2014

This is implemented using a new struct PartialVec which implements the proper
drop semantics in case the conversion is interrupted by an unwind.

For the old pull request, see #15302.

@tbu-
Add support for in-place map for Vecs of types with same size
0f7e093 
This is implemented using a new struct `PartialVec` which implements the proper
drop semantics in case the conversion is interrupted by an unwind.
@tbu-
PartialVec: Remove TODOs and rename unwrap to into_vec
3032fc1
@tbu-
Fix some of the issues mentioned in the PR on Github
371bea7 
This specifically includes:
- Fix of the tests
- Remove `transmute` between `Vec`s of different types
@tbu-
Check that the min_align_of the both types in a PartialVec matches
e009e49 
This is important because the underlying allocator of the `Vec` passes that
information to the deallocator which needs the guarantee that it is the same
parameters that were also passed to the allocation function.
@tbu-
Copy link
Contributor Author

tbu- commented Aug 8, 2014

The transmute of the Vecs has been removed (which relied on details of the unspecified struct layout), the min_align_of of the two types T and U is now checked.

@alexcrichton
Copy link
Member

Closing due to inactivity (21 days inactive)

@tbu- tbu- mentioned this pull request Aug 29, 2014
Merged
bors added a commit that referenced this pull request Sep 15, 2014
@bors
auto merge of #16853 : tbu-/rust/pr_mapinplace, r=aturon
e4771d1 
This is implemented using a new struct PartialVec which implements the proper
drop semantics in case the conversion is interrupted by an unwind.

For the old pull requests, see #15302, #16369.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 21, 2024
@bors
Auto merge of rust-lang#16369 - Veykril:simplify, r=Veykril
e7a8d21 
minor: Simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbu- @alexcrichton