Deprecate libnum in favor of rust-lang/num #17309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I wasn't sure what, if anything, to do with shootout-pidigits.rs in this PR. It doesn't seem like it should block us moving @brson thoughts? |
|
I would expect |
|
OK, I can do that. I just wasn't sure what the rules around shootout benchmarks were. |
This is part of the migration of crates into the Cargo ecosystem. There is now an external repository https://github.com/rust-lang/num for bignums. The single use of libnum elsewhere in the repository is for a shootout benchmark, which is being moved into the external crate. Due to deprecation, this is a: [breaking-change]
aturon
force-pushed
the
deprecate-libnum
branch
from
23adf58
to
2ff07af
Compare
|
FYI: added the benchmark to I've updated this PR accordingly. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the migration of crates into the Cargo ecosystem. There
is now an external repository https://github.com/rust-lang/num for bignums.
The single use of libnum elsewhere in the repository is for a shootout
benchmark. This commit does not attempt to remove that usage for now.
Due to deprecation, this is a:
[breaking-change]