Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase errors in std::io::fs #17589

Closed
wants to merge 1 commit into from

Conversation

globin
Copy link
Contributor

@globin globin commented Sep 27, 2014

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

@aturon
Copy link
Member

aturon commented Sep 29, 2014

@globin Thanks for the PR!

I think in general our errors are not very consistent about casing, but I believe that fully lower case is the norm. @alexcrichton can you confirm?

In any case, it would be worthwhile creating an explicit convention about this. Are you interested in writing an RFC to set up such a convention? I'd be happy to help.

@alexcrichton
Copy link
Member

For the compiler itself at least we have a convention that all errors are entirely lower-case. I don't think we have a hard-and-fast rule about library errors, and I imagine you'll find any number of strategies throughout! That being said, I agree with @aturon that we should probably standardize on this, and standardizing on all lower-case seems ok to do!

@aturon
Copy link
Member

aturon commented Oct 3, 2014

I've now proposed an explicit convention for lower-case errors. I'm going to close this PR for now; feel free to comment on the RFC if you feel the convention should be different, however.

@aturon aturon closed this Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants