Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow Fn unboxed closures to mutate upvars #17784

Merged
merged 4 commits into from
Oct 9, 2014
Merged

Don't allow Fn unboxed closures to mutate upvars #17784

merged 4 commits into from
Oct 9, 2014

Commits on Oct 5, 2014

  1. Track kind of closure in upvar categorization 

    Keep track of the kind of closure responsible for an upvar
    @bkoropoff
    bkoropoff committed Oct 5, 2014
    Configuration menu
    Copy the full SHA
    ea3ab73 View commit details
    Browse the repository at this point in the history

  2. Categorize upvars in Fn unboxed closures as freely aliasable 

    This causes borrowck to correctly reject mutation or mutable borrows
of upvars in `Fn` unboxed closures since the closure environment is
aliasable.

This also tracks the responsible closure in the aliasability
information returned and uses it to give a helpful diagnostic.

Closes issue rust-lang#17780
    @bkoropoff
    bkoropoff committed Oct 5, 2014
    Configuration menu
    Copy the full SHA
    f74b1c4 View commit details
    Browse the repository at this point in the history

  3. Fix unit test that was illegally mutating an upvar

    @bkoropoff
    bkoropoff committed Oct 5, 2014
    Configuration menu
    Copy the full SHA
    16b27bb View commit details
    Browse the repository at this point in the history

  4. Add regression test for issue rust-lang#17780

    @bkoropoff
    bkoropoff committed Oct 5, 2014
    5 Configuration menu
    Copy the full SHA
    4d2ff43 View commit details
    Browse the repository at this point in the history