Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debuginfo: Activate LLDB tests on Darwin. #18092

Merged
merged 5 commits into from Oct 22, 2014

Conversation

michaelwoerister
Copy link
Member

Now that there are build bots with a stable enough LLDB version on OSX we can finally let the tests run on every PR!
😹

@michaelwoerister
Copy link
Member Author

cc @alexcrichton

@alexcrichton
Copy link
Member

Awesome work @michaelwoerister!

@michaelwoerister
Copy link
Member Author

Whoops, it seems that I have broken GDB tests depending on breakpoints at specific line numbers. I'll fix them when I get to a computer...

On October 16, 2014 5:31:41 PM CEST, Alex Crichton notifications@github.com wrote:

Awesome work @michaelwoerister!


Reply to this email directly or view it on GitHub:
#18092 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@michaelwoerister michaelwoerister force-pushed the lldb-test-versioning branch 2 times, most recently from b86325c to def11e0 Compare October 18, 2014 17:09
@michaelwoerister
Copy link
Member Author

The tests should be fixed now.

@michaelwoerister
Copy link
Member Author

I'm not sure what went wrong the last time. It said that it couldn't create the debugger 'target', meaning that it probably didn't find the executable to debug (or couldn't access it because of access rights or code signing issues). Interestingly it worked on the try branch just now, without any change. Both times it ran on bot mac6.

I've added some more output to the LLDB script, so if it fails again, I should hopefully be able to find out what the actual problem was.

bors added a commit that referenced this pull request Oct 22, 2014
…alexcrichton

Now that there are build bots with a stable enough LLDB version on OSX we can finally let the tests run on every PR!
:joy_cat:
bors added a commit that referenced this pull request Oct 22, 2014
…alexcrichton

Now that there are build bots with a stable enough LLDB version on OSX we can finally let the tests run on every PR!
:joy_cat:
@bors bors closed this Oct 22, 2014
@bors bors merged commit 423dca7 into rust-lang:master Oct 22, 2014
@michaelwoerister
Copy link
Member Author

Alright! So the tests were actually executed two times, once on mac5 and once on mac6. On mac4 they have been ignored as they should be.
I'm a little worried that testing got a bit less deterministic. In theory it may be possible that the tests are not run at all for a PR because testing only runs on machines where LLDB is too old. That could lead to a regression being introduced but showing up only later for PRs that don't have anything to do with the problem. We'll see if that becomes a problem in practice.
Thanks, Alex, for all the help with figuring out what to do with the build system!

@alexcrichton
Copy link
Member

I think that we're guaranteed at least for now that at least one build will run on mac5 or mac6 (b/c mac4 can't run all the builds at once), so we should be somewhat ok on that front (hopefully not too bad!).

Awesome work @michaelwoerister, so glad to see these tests checked in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants