Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register new snapshots #18259

Merged
merged 1 commit into from Oct 28, 2014
Merged

Register new snapshots #18259

merged 1 commit into from Oct 28, 2014

Conversation

alexcrichton
Copy link
Member

This in theory enables uncommenting IndexMut implementations, but upon doing so
the compiler immediately segfaulted in stage1, so I'll leave those to a later
time.

This in theory enables uncommenting IndexMut implementations, but upon doing so
the compiler immediately segfaulted in stage1, so I'll leave those to a later
time.
@alexcrichton
Copy link
Member Author

I first attempted to land alexcrichton@e3dac1e, but that commit segfaulted instantly with this backtrace:

$ gdb --args ./x86_64-unknown-linux-gnu/stage1/bin/rustc src/libcore/lib.rs
GNU gdb (Ubuntu 7.7-0ubuntu3.1) 7.7
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ./x86_64-unknown-linux-gnu/stage1/bin/rustc...(no debugging symbols found)...done.
(gdb) r
Starting program: /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/rustc src/libcore/lib.rs
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff2bff480 (LWP 18546)]

Program received signal SIGILL, Illegal instruction.
[Switching to Thread 0x7ffff2bff480 (LWP 18546)]
0x00007ffff7e84278 in bitv::Bitv::set::h693713f7b138c463Yla () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustrt-4e7c5e5c.so
(gdb) bt
#0  0x00007ffff7e84278 in bitv::Bitv::set::h693713f7b138c463Yla () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustrt-4e7c5e5c.so
#1  0x00007ffff7e88574 in bitv::BitvSet.MutableSet$LT$uint$GT$::insert::h437317dbaeae41b5i8a () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustrt-4e7c5e5c.so
#2  0x00007ffff4313f72 in attr::first_attr_value_str_by_name::h23b9b3a677724c717XC () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/./libsyntax-4e7c5e5c.so
#3  0x00007ffff434d0bc in parse::parser::Parser$LT$$x27a$GT$::eval_src_mod::hac338816627dce54NaQ () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/./libsyntax-4e7c5e5c.so
#4  0x00007ffff433ee8e in parse::parser::Parser$LT$$x27a$GT$::parse_item_or_view_item::h56365d466ced5143sEQ ()
   from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/./libsyntax-4e7c5e5c.so
#5  0x00007ffff4346846 in parse::parser::Parser$LT$$x27a$GT$::parse_items_and_view_items::h6c430a0fa80b713eT6Q ()
   from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/./libsyntax-4e7c5e5c.so
#6  0x00007ffff434ae70 in parse::parser::Parser$LT$$x27a$GT$::parse_mod_items::hf066dcd3ed21aeb821P () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/./libsyntax-4e7c5e5c.so
#7  0x00007ffff43549ef in parse::parser::Parser$LT$$x27a$GT$::parse_crate_mod::h4947cca241ec7fec9bR () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/./libsyntax-4e7c5e5c.so
#8  0x00007ffff43acabd in parse::parse_crate_from_file::h100116cb38a295e7NsV () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/./libsyntax-4e7c5e5c.so
#9  0x00007ffff71658f0 in driver::driver::phase_1_parse_input::closure.142527 () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustc-4e7c5e5c.so
#10 0x00007ffff715c5a2 in driver::driver::phase_1_parse_input::h4f0913c2647baa03ibA () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustc-4e7c5e5c.so
#11 0x00007ffff7159feb in driver::driver::compile_input::hd529ab663911c532g6z () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustc-4e7c5e5c.so
#12 0x00007ffff71b99cf in driver::run::closure.147104 () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustc-4e7c5e5c.so
#13 0x00007ffff71c4327 in task::TaskBuilder$LT$S$GT$::try_future::closure.147673 () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustc-4e7c5e5c.so
#14 0x00007ffff71c42d8 in task::TaskBuilder$LT$S$GT$::spawn_internal::closure.147667 () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustc-4e7c5e5c.so
#15 0x00007ffff7fc287f in task::NativeSpawner.Spawner::spawn::closure.8465 () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/libnative-4e7c5e5c.so
#16 0x00007ffff7edd6ec in rust_try_inner () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustrt-4e7c5e5c.so
#17 0x00007ffff7edd6d6 in rust_try () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustrt-4e7c5e5c.so
#18 0x00007ffff7e7d0c3 in unwind::try::hc8101bb7ca759647imd () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustrt-4e7c5e5c.so
#19 0x00007ffff7e7ed5c in task::Task::run::hb7a787d36e5bed95WBc () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustrt-4e7c5e5c.so
#20 0x00007ffff7fc26f8 in task::NativeSpawner.Spawner::spawn::closure.8406 () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/libnative-4e7c5e5c.so
#21 0x00007ffff7e7cec8 in thread::thread_start::h9a3d162da155dd197Vc () from /home/alex/code/rust3/x86_64-unknown-linux-gnu/stage1/bin/../lib/librustrt-4e7c5e5c.so
#22 0x00007ffff6633182 in start_thread (arg=0x7ffff2bff480) at pthread_create.c:312
#23 0x00007ffff6bdffbd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 27, 2014
@bors bors merged commit 398b287 into rust-lang:master Oct 28, 2014
bors added a commit that referenced this pull request Oct 28, 2014
This PR changes the signature of several methods from `foo(self, ...)` to `foo(&self, ...)`/`foo(&mut self, ...)`, but there is no breakage of the usage of these methods due to the autoref nature of `method.call()`s. This PR also removes the lifetime parameter from some traits (`Trait<'a>` -> `Trait`). These changes break any use of the extension traits for generic programming, but those traits are not meant to be used for generic programming in the first place. In the whole rust distribution there was only one misuse of a extension trait as a bound, which got corrected (the bound was unnecessary and got removed) as part of this PR.

I've kept the commits as small and self-contained as possible for reviewing sake, but I can squash them when the review is over.

See this [table] to get an idea of what's left to be done. I've already DSTified [`Show`][show] and I'm working on `Hash`, but bootstrapping those changes seem to require a more recent snapshot (#18259 does the trick)

r? @aturon 
cc #16918 

[show]: https://github.com/japaric/rust/commits/show
[table]: https://docs.google.com/spreadsheets/d/1MZ_iSNuzsoqeS-mtLXnj9m0hBYaH5jI8k9G_Ud8FT5g/edit?usp=sharing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants