Disallow coercions from [T, ..n] to &[T] #18645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Part of #18469 |
| @@ -576,11 +576,11 @@ pub trait MutableSliceAllocating<T> for Sized? { | |||
| /// ```rust | |||
| /// let mut v = [5i, 4, 1, 3, 2]; | |||
| /// v.sort_by(|a, b| a.cmp(b)); | |||
| /// assert!(v == [1, 2, 3, 4, 5]); | |||
| /// assert!(v == &[1, 2, 3, 4, 5]); | |||
There was a problem hiding this comment.
I'm under the impression that this change won't be necessary once #18486 lands. Since [T, ..N] == [T, ..N] works up to N = 32. cc @nikomatsakis
|
r=me, thanks @nick29581! |
bors
added a commit
that referenced
this pull request
Nov 17, 2014
The forwards compatible parts of #18645, rebased. Converts implicit coercions from `[T, ..n]` to `&[T]` into explicit references.
[breaking-change] Insert an `&` to fix
bors
added a commit
that referenced
this pull request
Nov 18, 2014
r? (I realise this needs a rebase, but I will probably have to chop it up in order to land and I'd like to get r+ first so I can do that quicker)
This was referenced Nov 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r?
(I realise this needs a rebase, but I will probably have to chop it up in order to land and I'd like to get r+ first so I can do that quicker)