Fix "::::" appearing in module_path!() #19262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fld.cx.mod_push(it.ident); | ||
| if it.ident.name != parse::token::special_idents::invalid.name { | ||
| fld.cx.mod_push(it.ident); | ||
| } |
There was a problem hiding this comment.
Shouldn't the mod_pop underneath this also be conditional? (is this why the unwrap above was removed?)
There was a problem hiding this comment.
Yes, that's why the unwrap was removed. I suppose they could both be conditional. I was thinking a pop function returning an Option (and letting the caller deal with it) instead of unwrapping it made some sense, but now I realize that mod_pop doesn't return anything. This function is the only place mod_push and mod_pop are used, so it's not breaking any code elsewhere. Still, I can make the change for the sake of it making more sense at a glance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18859