Implement the Fn trait for bare fn pointers in the compiler
#19449
Conversation
nikomatsakis
force-pushed
the
unboxed-closure-fn-impl
branch
from
ad91b79
to
e02c49a
Compare
|
r? @pcwalton |
|
Could it be that this fixes #19126? 😍 I'll give it a go! |
nikomatsakis
force-pushed
the
unboxed-closure-fn-impl
branch
from
e02c49a
to
4960a5a
Compare
|
@japaric that was the idea :) |
nikomatsakis
force-pushed
the
unboxed-closure-fn-impl
branch
from
4960a5a
to
32252c1
Compare
|
Very happy to see this being fixed :) |
|
@nikomatsakis I always get this LLVM assertion:
I'll investigate it later, and open an issue with some minimal reproduction script. (But my guess, is that is something cross-crate related) |
|
@japaric hmm, ok. I'll add some cross-crate tests. It also occurs to me I forgot to add the cache that I meant to add, so right now it generates fresh adapters as needed. |
|
The requirement for the |
| }; | ||
|
|
||
| let arguments_tuple = ty::mk_tup(self.tcx(), sig.inputs.to_vec()); | ||
| let output_type = sig.output.unwrap(); |
There was a problem hiding this comment.
Since you cloned the sig above, why not just move inputs and output out?
There was a problem hiding this comment.
good point, holdover from an older version where I needed the clone for something
…than doing it using hard-coded impls. This means that it works also for more complex fn types involving bound regions. Fixes rust-lang#19126.
nikomatsakis
force-pushed
the
unboxed-closure-fn-impl
branch
from
669e59d
to
f2731ff
Compare
…cwalton Implement the `Fn` trait for bare fn pointers in the compiler rather than doing it using hard-coded impls. This means that it works also for more complex fn types involving bound regions.
|
Could someone make a snapshot containing this change? This is needed to land the migration to unboxed closures patch. |
|
One should be on the way! |
Implement the
Fntrait for bare fn pointers in the compiler ratherthan doing it using hard-coded impls. This means that it works also
for more complex fn types involving bound regions.