Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend -Z print-region-graph with enclosing edges #21982

Merged
merged 2 commits into from
Feb 7, 2015

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Feb 5, 2015

Extend region-inference graphviz rendering with enclosing relationship as well as the constraint edges.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Member Author

pnkfelix commented Feb 5, 2015

r? @nikomatsakis

@pnkfelix
Copy link
Member Author

pnkfelix commented Feb 5, 2015

(this was spawned off of #21972, but it does not actually block the work there. I found the extra information added by this PR useful at times, but it also introduces noise into the generated graphs. Perhaps I will need to move all of this over to a proper unstable-option where I can specify variants, rather than relying on -Z flags.)

@nikomatsakis
Copy link
Contributor

@bors r+ 576ba8f

I agree though that we'll prob want the ability to customize this more.

@bors
Copy link
Contributor

bors commented Feb 7, 2015

⌛ Testing commit 576ba8f with merge 4bb2d9c...

@bors
Copy link
Contributor

bors commented Feb 7, 2015

💔 Test failed - auto-mac-64-opt

@pnkfelix
Copy link
Member Author

pnkfelix commented Feb 7, 2015

@bors r=nikomatsakis 7610feb

bors added a commit that referenced this pull request Feb 7, 2015
…tsakis

Extend region-inference graphviz rendering with enclosing relationship as well as the constraint edges.
@bors
Copy link
Contributor

bors commented Feb 7, 2015

⌛ Testing commit 7610feb with merge ce5aad2...

@bors bors merged commit 7610feb into rust-lang:master Feb 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants