Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pending RFC] Const functions and inherent methods. #22816

Closed
wants to merge 4 commits into from

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Feb 25, 2015

[DO NOT MERGE] RFC is rust-lang/rfcs#911.
r? @nikomatsakis

@bors
Copy link
Contributor

bors commented Feb 25, 2015

☔ The latest upstream changes (presumably #22796) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb
Copy link
Member Author

eddyb commented Feb 26, 2015

I've had to remove the commit using const fns at stage1 and later because I forgot #[cfg(not(stage0))] won't save me from parse errors.
It's a bit sad that I did all that annotation work for nothing - after a snapshot it can be done with no stage0 compatibility concerns, though I'll likely reuse the implementation and just remove the #[cfg(stage)] parts.

@bors
Copy link
Contributor

bors commented Feb 28, 2015

☔ The latest upstream changes (presumably #22801) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 12, 2015

☔ The latest upstream changes (presumably #23298) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 18, 2015

☔ The latest upstream changes (presumably #23473) made this pull request unmergeable. Please resolve the merge conflicts.

@nikomatsakis
Copy link
Contributor

The RFC has been accepted now. Sorry that took so long. There was this little issue of a 1.0 beta release; kind of distracting. Anyway, @eddyb indicated on IRC that he wont' have much time lately, so I plan to adopt and rebase this PR.

@nikomatsakis
Copy link
Contributor

I'm going to close this PR. I have a rebased version locally that I will hopefully open soon (just have to resolve one or two minor errors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants