std: Tweak some unstable features of str
#23461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gankro (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @aturon |
|
cc #9387, but doesn't quite fix it as there is still a decision left to be made |
|
@bors: r+ 53f493c |
This commit clarifies some of the unstable features in the `str` module by moving them out of the blanket `core` and `collections` features. The following methods were moved to the `str_char` feature which generally encompasses decoding specific characters from a `str` and dealing with the result. It is unclear if any of these methods need to be stabilized for 1.0 and the most conservative route for now is to continue providing them but to leave them as unstable under a more specific name. * `is_char_boundary` * `char_at` * `char_range_at` * `char_at_reverse` * `char_range_at_reverse` * `slice_shift_char` The following methods were moved into the generic `unicode` feature as they are specifically enabled by the `unicode` crate itself. * `nfd_chars` * `nfkd_chars` * `nfc_chars` * `graphemes` * `grapheme_indices` * `width`
alexcrichton
force-pushed
the
feat-char-at
branch
from
53f493c
to
aa88da6
Compare
|
@bors: r=aturon |
|
📌 Commit aa88da6 has been approved by |
| break; | ||
| } | ||
| i = range.next; | ||
| i += ch.len_utf8(); |
There was a problem hiding this comment.
I have to wonder whether LLVM would optimize out this operation (decoding from UTF-8 and getting the length from the result of the decoding, instead of having it as a by-product) on @Kimundi's utf8x4 semi-hypothetical replacement for char.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 18, 2015
This commit clarifies some of the unstable features in the `str` module by moving them out of the blanket `core` and `collections` features. The following methods were moved to the `str_char` feature which generally encompasses decoding specific characters from a `str` and dealing with the result. It is unclear if any of these methods need to be stabilized for 1.0 and the most conservative route for now is to continue providing them but to leave them as unstable under a more specific name. * `is_char_boundary` * `char_at` * `char_range_at` * `char_at_reverse` * `char_range_at_reverse` * `slice_shift_char` The following methods were moved into the generic `unicode` feature as they are specifically enabled by the `unicode` crate itself. * `nfd_chars` * `nfkd_chars` * `nfc_chars` * `graphemes` * `grapheme_indices` * `width`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit clarifies some of the unstable features in the
strmodule bymoving them out of the blanket
coreandcollectionsfeatures.The following methods were moved to the
str_charfeature which generallyencompasses decoding specific characters from a
strand dealing with theresult. It is unclear if any of these methods need to be stabilized for 1.0 and
the most conservative route for now is to continue providing them but to leave
them as unstable under a more specific name.
is_char_boundarychar_atchar_range_atchar_at_reversechar_range_at_reverseslice_shift_charThe following methods were moved into the generic
unicodefeature as they arespecifically enabled by the
unicodecrate itself.nfd_charsnfkd_charsnfc_charsgraphemesgrapheme_indiceswidth