Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests checking that a number of feature gates are gating their feat... #23578

Merged
merged 1 commit into from Mar 23, 2015

Conversation

fhahn
Copy link
Contributor

@fhahn fhahn commented Mar 21, 2015

...ures.

Namely:

  • box_syntax
  • box_patterns
  • simd_ffi
  • macro_reexport

cc #22820

@rust-highfive
Copy link
Collaborator

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@fhahn fhahn force-pushed the issue-22820-feature-gate-tests1 branch 2 times, most recently from fc2e7fa to 829768c Compare March 21, 2015 09:17
…eatures.

Namely:

 * `box_syntax`
 * `box_patterns`
 * `simd_ffi`
 * `macro_reexport`

 cc rust-lang#22820
@fhahn fhahn force-pushed the issue-22820-feature-gate-tests1 branch from 829768c to c48bb85 Compare March 21, 2015 09:18
@alexcrichton
Copy link
Member

@bors: r+ c48bb85

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 21, 2015
…s1, r=alexcrichton

 ...ures.

Namely:

 * `box_syntax`
 * `box_patterns`
 * `simd_ffi`
 * `macro_reexport`

cc rust-lang#22820
@bors
Copy link
Contributor

bors commented Mar 21, 2015

⌛ Testing commit c48bb85 with merge 07fad65...

@bors
Copy link
Contributor

bors commented Mar 21, 2015

💔 Test failed - auto-mac-64-nopt-t

@fhahn
Copy link
Contributor Author

fhahn commented Mar 22, 2015

The build failed in with Failed setproperty before actually running the tests.

@alexcrichton
Copy link
Member

@bors: retry

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 22, 2015
…s1, r=alexcrichton

 ...ures.

Namely:

 * `box_syntax`
 * `box_patterns`
 * `simd_ffi`
 * `macro_reexport`

cc rust-lang#22820
@bors
Copy link
Contributor

bors commented Mar 23, 2015

⌛ Testing commit c48bb85 with merge 1946dff...

@bors
Copy link
Contributor

bors commented Mar 23, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Mar 23, 2015 at 2:01 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4181


Reply to this email directly or view it on GitHub
#23578 (comment).

@bors bors merged commit c48bb85 into rust-lang:master Mar 23, 2015
@fhahn fhahn deleted the issue-22820-feature-gate-tests1 branch March 24, 2015 15:05
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 24, 2015
As part of the audit for rust-lang#22820 the following duplicate feature
gate tests were removed:

* `box_patterns`
* `simd_ffi`

These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578,
however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively.

r? @nrc
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 24, 2015
As part of the audit for rust-lang#22820 the following duplicate feature
gate tests were removed:

* `box_patterns`
* `simd_ffi`

These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578,
however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively.

r? @nrc
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 25, 2015
As part of the audit for rust-lang#22820 the following duplicate feature
gate tests were removed:

* `box_patterns`
* `simd_ffi`

These tests for `box_patterns` and `simd_ffi` were added in rust-lang#23578,
however there were existing tests in rust-lang#20723 and rust-lang#21233 respectively.

r? @nrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants