Implemented remaining string pattern API #23952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #23955) made this pull request unmergeable. Please resolve the merge conflicts. |
Kimundi
force-pushed
the
more_string_pattern
branch
4 times, most recently
from
ee8c14a
to
bfa1cab
Compare
| /// | ||
| /// The returned iterator will be double ended if the pattern allows a reverse search | ||
| /// and forward/reverse search yields the same elements. This is true for, eg, `char` but not | ||
| /// for `&str`. |
There was a problem hiding this comment.
Much of the surrounding style of documentation in this file is to wrap to 80 chars, could you also do that here?
|
Overall this looks good to me, but I'm finding it very difficult to follow with the large amount of macros being used, would you mind trying to reduce the number of macros in use? I think some extra verboseness is fine here as we're not really trying to optimize for disk space with the source code! |
Kimundi
force-pushed
the
more_string_pattern
branch
2 times, most recently
from
83bb01a
to
76fad7e
Compare
- Added missing reverse versions of methods - Added [r]matches() - Generated the string pattern iterators with a macro - Added where bounds to the methods returning reverse iterators for better error messages.
Fixed bug in existing StrSearcher impl
Kimundi
force-pushed
the
more_string_pattern
branch
from
76fad7e
to
fbba28e
Compare
bors
added a commit
that referenced
this pull request
Apr 7, 2015
This adds the missing methods and turns `str::pattern` in a user facing module, as per RFC. This also contains some big internal refactorings: - string iterator pairs are implemented with a central macro to reduce redundancy - Moved all tests from `coretest::str` into `collectionstest::str` and left a note to prevent the two sets of tests drifting apart further. See #22477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing methods and turns
str::patternin a user facing module, as per RFC.This also contains some big internal refactorings:
coretest::strintocollectionstest::strand left a note to prevent the two sets of tests drifting apart further.See #22477