rustc: Fix more verbatim paths leaking to gcc #25134
Conversation
Turns out that a verbatim path was leaking through to gcc via the PATH environment variable (pointing to the bundled gcc provided by the main distribution) which was wreaking havoc when gcc itself was run. The fix here is to just stop passing verbatim paths down by adding more liberal uses of `fix_windows_verbatim_for_gcc`. Closes rust-lang#25072
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
fix-issue-25072-for-realsies
branch
from
02a3fef
to
2dc0e56
Compare
|
@bors r+ p=1 |
|
📌 Commit 2dc0e56 has been approved by |
…rson Turns out that a verbatim path was leaking through to gcc via the PATH environment variable (pointing to the bundled gcc provided by the main distribution) which was wreaking havoc when gcc itself was run. The fix here is to just stop passing verbatim paths down by adding more liberal uses of `fix_windows_verbatim_for_gcc`. Closes #25072
|
Uh. This raises another question: is there more risks to use "verbatim" |
|
@klutzy we're not intentionally canonicalizing to verbatim paths, it's just a side effect of using |
|
@alexcrichton Perhaps the |
|
I'd prefer to not add special behavior to various modules to work around bugs in MinGW's gcc or ld, although Windows 7 not understanding them at all in |
Turns out that a verbatim path was leaking through to gcc via the PATH
environment variable (pointing to the bundled gcc provided by the main
distribution) which was wreaking havoc when gcc itself was run. The fix here is
to just stop passing verbatim paths down by adding more liberal uses of
fix_windows_verbatim_for_gcc.Closes #25072