Create a FreshFloatTy separate from FreshIntTy #25344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no subtyping relationship between the types (or their non-freshened variants), so they can not be merged. Fixes rust-lang#22645 Fixes rust-lang#24352 Fixes rust-lang#23825 Should fix rust-lang#25235 (no test in issue). Should fix rust-lang#19976 (test is outdated).
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 36eb09f has been approved by |
|
⌛ Testing commit 36eb09f with merge 222cd73... |
|
@arielb1 That is an impressive number of issues fixed in one fell swoop! Very nice 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no subtyping relationship between the types (or their non-freshened
variants), so they can not be merged.
Fixes #22645
Fixes #24352
Fixes #23825
Fixes #25235 (no test in issue).
Fixes #19976 (test is outdated).
Fixes #18623.
Fixes #18954
Fixes #23722
Fixes #24138