Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_typeck: export modules and fields for sub-passes. #25390

Merged
merged 1 commit into from May 20, 2015

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented May 13, 2015

Needed for driving parts of type-checking manually.

@rust-highfive
Copy link
Collaborator

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@llogiq
Copy link
Contributor

llogiq commented May 19, 2015

👍, this would really help with rust-clippy.

@nrc
Copy link
Member

nrc commented May 20, 2015

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 20, 2015

📌 Commit 65f3067 has been approved by nrc

@pythonesque
Copy link
Contributor

This seems like it will make it much harder to refactor typeck. Are we not worried about breaking its consumers at this juncture?

@llogiq
Copy link
Contributor

llogiq commented May 20, 2015

For the record, I'm absolutely ok with any breakage until it's stabilized. Generally, I feel that if I use unstable APIs, even if publicly available, any breakage that may occur is my problem.

Btw. I found a way to implement my lint without requiring method lookup, at the cost of possible false positives, so the method lookup could be considered optional in this case. However, method lookup will still be quite useful for other lints – e.g. for suggesting methods or suppress warnings depending on availability.

@bors
Copy link
Contributor

bors commented May 20, 2015

⌛ Testing commit 65f3067 with merge cfceeca...

bors added a commit that referenced this pull request May 20, 2015
Needed for driving parts of type-checking manually.
@bors bors merged commit 65f3067 into rust-lang:master May 20, 2015
@eddyb eddyb deleted the typeck-pub branch May 20, 2015 18:00
@nrc
Copy link
Member

nrc commented May 20, 2015

@pythonesque no - just because it is public doesn't mean it is stable. Anyone who uses compiler internals should be prepared for breakage at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants