Add 8 more error explanations. #25398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2015 19:55
This also updates the error messages for both. For E0066, it removes mention of "managed heap", which was removed in 8a91d33. For E0069, I just tweaked the wording to make it a bit more explicit.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| An example of this error: | ||
|
|
||
| ``` | ||
| use foo::FOO; // error, do `use foo::FOO as BAR` instead |
There was a problem hiding this comment.
Maybe this could be something like
use bar::foo;
fn foo() {}
mod bar {
pub fn foo() {}
}(I just find the upper-case FOO slightly strange.)
There was a problem hiding this comment.
Thanks, that's a much better.
|
@bors r+ rollup |
|
📌 Commit 7a5152e has been approved by |
|
@huonw I just added one more change (and squashed it into the previous commit). Do you need to approve again? (Sorry) |
|
Yep, any changes means a reapproval is needed (don't apologise, having more improvements is better than having less improvements). @bors r+ rollup |
|
📌 Commit 588777f has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 14, 2015
Adds explanations for E0053, E0066, E0069, E0251, E0252, E0255, E0256, E0368. cc rust-lang#24407
bors
added a commit
that referenced
this pull request
May 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explanations for E0053, E0066, E0069, E0251, E0252, E0255, E0256, E0368.
cc #24407