Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change headers in Traits section of the book #29194

Merged
merged 2 commits into from
Oct 23, 2015

Conversation

corincerami
Copy link
Contributor

It's possible that there is some meaning I'm not grasping from the headers "Traits bounds for generic functions" and "Traits bounds for generic structs", but they seem to me like they could be clearer and more grammatically correct.

@rust-highfive
Copy link
Collaborator

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@corincerami
Copy link
Contributor Author

Looking around the docs in the source, I do see the term bounds being used a few times to refer to constraints on types, so maybe this is a widely accepted term I'm unfamiliar with? At the very least, I think it would be helpful to elaborate/clarify this somewhere in the Traits chapter of the book.

@Manishearth
Copy link
Member

The term used for this is bounds, constraints is rarely used. We could, however, explain what it means somewhere. Or add it to the reference.

@steveklabnik thoughts?

@steveklabnik
Copy link
Member

"Bounds" is the more specific term that people use, yes. Maybe adding it to the Glossary would make sense?

@Manishearth
Copy link
Member

👍

@corincerami
Copy link
Contributor Author

That sounds reasonable to me. I had a suspicion it might be the correct term, but I wasn't sure. Shall I update this PR to add it to the glossary instead?

@Manishearth
Copy link
Member

Yes! 😄

@corincerami
Copy link
Contributor Author

I've updated this PR to instead add bounds to the glossary. I've also tried to make traits.md a bit more consistent at using bounds as the preferred terminology, as constraint was previously used more commonly in that chapter.

@Manishearth
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 23, 2015

📌 Commit 00c1419 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Oct 23, 2015

⌛ Testing commit 00c1419 with merge 9a85566...

bors added a commit that referenced this pull request Oct 23, 2015
…=Manishearth

It's possible that there is some meaning I'm not grasping from the headers "Traits bounds for generic functions" and "Traits bounds for generic structs", but they seem to me like they could be clearer and more grammatically correct.
@bors bors merged commit 00c1419 into rust-lang:master Oct 23, 2015
@corincerami corincerami deleted the clarify-headers-in-traits-docs branch October 23, 2015 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants