Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add example for std::fs::DirBuilder #30190

Merged
merged 1 commit into from Dec 4, 2015
Merged

doc: add example for std::fs::DirBuilder #30190

merged 1 commit into from Dec 4, 2015

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Dec 3, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

/// #![feature(dir_builder)]
/// use std::path::Path;
///
/// let path = Path::new("/tmp/foo/bar/baz");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This takes P: AsRef<Path> so idiomatically with a string literal you wouldn't also wrap it up in a Path but would instead just pass it through.

@tshepang
Copy link
Member Author

tshepang commented Dec 3, 2015

nice feedback, thanks @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ 4463070

@bors
Copy link
Contributor

bors commented Dec 4, 2015

⌛ Testing commit 4463070 with merge 4cedff7...

1 similar comment
@bors bors merged commit 4463070 into rust-lang:master Dec 4, 2015
@tshepang tshepang deleted the dir_builder-example branch December 4, 2015 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants