Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E0463 error explanation #30264

Merged
merged 2 commits into from Jan 2, 2016
Merged

Add E0463 error explanation #30264

merged 2 commits into from Jan 2, 2016

Conversation

GuillaumeGomez
Copy link
Member

r? @Manishearth

Also: should I merged both commits? Not sure if it's really useful to keep the first one.

@@ -56,6 +56,18 @@ you want. Example:
```
"##,

E0463: r##"
A plugin was called but cannot be found. Erroneous code example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just mention crate here

@Manishearth
Copy link
Member

This still doesn't talk about crates, and focuses on plugins.

If the error really only occurs for plugins, the inline error should be improved first. If not, we should mention crates as well.

@@ -56,6 +56,19 @@ you want. Example:
```
"##,

E0463: r##"
A plugin/crate was called but cannot be found. Erroneous code example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was declared but not found

@Manishearth
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 2, 2016

📌 Commit 55955f5 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Jan 2, 2016

⌛ Testing commit 55955f5 with merge 4744472...

bors added a commit that referenced this pull request Jan 2, 2016
r? @Manishearth

Also: should I merged both commits? Not sure if it's really useful to keep the first one.
@bors bors merged commit 55955f5 into rust-lang:master Jan 2, 2016
@GuillaumeGomez GuillaumeGomez deleted the patch-5 branch January 2, 2016 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants