Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated APIs missed in #30182 #30351

Merged
merged 3 commits into from Dec 14, 2015

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Dec 12, 2015

issue = "27777")]
#[rustc_deprecated(since = "1.5.0", reason = "replaced with ... syntax")]
#[allow(deprecated)]
pub struct RangeInclusive<A> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually decided to leave this in for now as the replacement, ... syntax, has not yet been implemented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see; only .. is implemented. Restored.

@alexcrichton
Copy link
Member

Thanks @tamird! I think I got mixed up between PRs and too aggressively removed a few things. You may also want to remove the stage0 changes related to warnings as they're likely to conflict with #30352 and should be resolved there anyway.

@tamird tamird force-pushed the remove-range-inclusive branch 2 times, most recently from 85f4a20 to e236216 Compare December 12, 2015 17:11
@tamird
Copy link
Contributor Author

tamird commented Dec 12, 2015

Ah, didn't know #30352 was in flight. Removed the stage0 stuff

@alexcrichton
Copy link
Member

@bors: r+ d9dc69d731fba85b70bb72d408c770add5fd6c23

@bors
Copy link
Contributor

bors commented Dec 12, 2015

🙀 d9dc69d731fba85b70bb72d408c770add5fd6c23 is not a valid commit SHA. Please try again with e236216.

@alexcrichton
Copy link
Member

@bors: r+ e236216ddbae5939a7e2121f2349a8569c42c1a0

@tamird
Copy link
Contributor Author

tamird commented Dec 12, 2015

@alexcrichton CI failed because of the MutableByteVector test since #30182 removed the public reexport of slice::bytes. I've added that reexport back.

`match-arm-statics` covers this, but needs to be compiled with
debuginfo. However, that still produces an ICE. See rust-lang#29696.
@alexcrichton
Copy link
Member

@bors: r+ d477708

@bors
Copy link
Contributor

bors commented Dec 13, 2015

⌛ Testing commit d477708 with merge 110df04...

@bors bors merged commit d477708 into rust-lang:master Dec 14, 2015
@tamird tamird deleted the remove-range-inclusive branch December 14, 2015 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants