android has posix_memalign for API 16+ since NDK r10d

[tamird]

See: http://developer.android.com/ndk/downloads/revision_history.html

Also, use libc's posix_memalign.

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[brson]

@bors r+

[bors]

📌 Commit 2a88cd0 has been approved by brson

[tamird]

@brson: I rewrote this commit to remove some additional cruft while I'm here.

[nikomatsakis]

@bors r+

[bors]

📌 Commit 99cfe48 has been approved by nikomatsakis

[bors]

⌛ Testing commit 99cfe48 with merge 037e822...

[bors]

💔 Test failed - auto-linux-64-x-android-t

[tamird]

Ugh, this depends on rust-lang/libc#132

[alexcrichton]

Thanks for the PR! Although Android may have this API now, our nightlies are compiled against a pretty old version of the NDK to have a "maximally compatible" libstd. I think it's the case that posix_memalign isn't in that NDK, and this will likely fail CI with a link error on android (e.g. the symbol isn't defined).

Increasing the minimum supported Android version is likely out of the scope of this PR (as it affects other projects like Servo), but I'm willing to wait for the libc update to see if this passes CI. If it does, then it seems fine to me!

[brson]

Yes, we need to be careful about upgrading our minimum android requirements.

[tamird]

Cool beans. Let's see what the bots say!

[alexcrichton]

The libc changes have been merged now, so you should be able to include the submodule update here

[tamird]

Done.

On Mon, Jan 11, 2016 at 7:42 PM, Alex Crichton notifications@github.com
wrote:

The libc changes have been merged now, so you should be able to include
the submodule update here

—
Reply to this email directly or view it on GitHub
#30601 (comment).

[alexcrichton]

Maybe an amendment was forgotten? Looks like the submodule still hasn't been updated

[tamird]

Ah, sorry, I misunderstood you. Done now.

On Mon, Jan 11, 2016 at 8:41 PM, Alex Crichton notifications@github.com
wrote:

Maybe an amendment was forgotten? Looks like the submodule still hasn't
been updated

—
Reply to this email directly or view it on GitHub
#30601 (comment).

[alexcrichton]

@bors: r+ f834051274545c212b4429b9a45117e8c1ba0bea

[bors]

⌛ Testing commit f834051 with merge 21c4c0e...

[bors]

💔 Test failed - auto-linux-cross-opt

[tamird]

@alexcrichton looks like mips failed because of the following type mismatch in src/liblibc/src/unix/notbsd/linux/mips.rs:

pub struct sigaction {
    pub sa_flags: ::c_int,
    ...
}
...

pub const SA_ONSTACK: ::c_uint = 0x08000000;
pub const SA_SIGINFO: ::c_uint = 0x00000008;

[alexcrichton]

@tamird I've sent rust-lang/libc#135 and once that's merged I think that'll be fixed.

[alexcrichton]

Ok, libc update merged, should be good to re-update submodule and re-try

[tamird]

Done.

On Tue, Jan 12, 2016 at 3:04 PM, Alex Crichton notifications@github.com
wrote:

Ok, libc update merged, should be good to re-update submodule and re-try

—
Reply to this email directly or view it on GitHub
#30601 (comment).

[alexcrichton]

@bors: r+ 5657eef

[bors]

⌛ Testing commit 5657eef with merge 49c3827...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt