Update variance dep. graph edges to be more fine-grained #31394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
incr-comp-variance
branch
from
1770e2e
to
bd31812
Compare
|
done. |
|
cc @michaelwoerister (just b/c it's related to incr. comp.) |
nikomatsakis
force-pushed
the
incr-comp-variance
branch
2 times, most recently
from
97612e2
to
ade4a76
Compare
|
Travis failure looks bogus (this branch passes |
| // You would expect that `item.id == id`, but this | ||
| // is not always the case. In particular, for | ||
| // ViewPath like `use self::{mem, foo}`, we record | ||
| // map the ids for `mem` and `foo` to the |
There was a problem hiding this comment.
"we record map" ?
was that supposed to just be "we map" ?
|
☔ The latest upstream changes (presumably #31304) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@pnkfelix did you complete your review here? |
|
@nikomatsakis no i think I need to return to it |
map. Perhaps I ought to just add them instead, but this seems harmless enough.
be more fine-grained, fixing the `dep-graph-struct-signature` test.
nikomatsakis
force-pushed
the
incr-comp-variance
branch
from
ade4a76
to
01ebc37
Compare
|
@pnkfelix rebased |
|
@bors r+ |
|
📌 Commit 01ebc37 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the dep. graph edges created by variance just mirror the constraint graph.
Note that this extends #31304, so the first few commits are on a different topic.
r? @pnkfelix