remove dead #[derive(FromPrimitive)] code #31400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durka
force-pushed
the
civilized-deriving
branch
from
4b0c591
to
2a925f9
Compare
durka
force-pushed
the
civilized-deriving
branch
from
2a925f9
to
45e716e
Compare
alexcrichton
added
the
relnotes
|
Tagging with relnotes but this may not even warrant a mention |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 5, 2016
…chton You can `#[derive(FromPrimitive)]`, but it [fails later in the compile](https://play.rust-lang.org/?gist=82cb8ad2fac49e3fe472&version=stable) due to hardcoding `std::num::FromPrimitive` which [was removed](rust-lang@eeb9488) (for some reason Github doesn't show `FromPrimitive` in the diff, but `git show` does). Anyway, this PR removes the code. I didn't mark it as a breaking change, even though [this extremely contrived code using highly unstable features](https://play.rust-lang.org/?gist=1e1b1bbff962837b228a&version=nightly) is broken by it -- should I?
|
@bors force (another PR is still running but was requested to be cancelled by the author, forcing the next PR in queue) |
bors
added a commit
that referenced
this pull request
Feb 5, 2016
You can `#[derive(FromPrimitive)]`, but it [fails later in the compile](https://play.rust-lang.org/?gist=82cb8ad2fac49e3fe472&version=stable) due to hardcoding `std::num::FromPrimitive` which [was removed](eeb9488) (for some reason Github doesn't show `FromPrimitive` in the diff, but `git show` does). Anyway, this PR removes the code. I didn't mark it as a breaking change, even though [this extremely contrived code using highly unstable features](https://play.rust-lang.org/?gist=1e1b1bbff962837b228a&version=nightly) is broken by it -- should I?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can
#[derive(FromPrimitive)], but it fails later in the compile due to hardcodingstd::num::FromPrimitivewhich was removed (for some reason Github doesn't showFromPrimitivein the diff, butgit showdoes).Anyway, this PR removes the code. I didn't mark it as a breaking change, even though this extremely contrived code using highly unstable features is broken by it -- should I?