mk: Pass CFLAGS for target, not host #33381
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit 4d7dcc6 has been approved by |
|
Giving higher priorities because nightlies need to be working. |
mk: Pass CFLAGS for target, not host This changes the CFLAGS and related variables passed to compiletest to be passed for the target, not the host, so we can correctly test 32-bit cross compiles on 64-bit host machines. Hopefuly fixes #33379
|
💔 Test failed - auto-linux-musl-64-opt |
This changes the CFLAGS and related variables passed to compiletest to be passed for the target, not the host, so we can correctly test 32-bit cross compiles on 64-bit host machines. Hopefuly fixes rust-lang#33379
alexcrichton
force-pushed
the
fix-nightlies
branch
from
4d7dcc6
to
74d1520
Compare
|
Everything is terrible for forever! I've updated to just skip run-make tests on cross builds, as that's apparently what we've always done. |
mk: Pass CFLAGS for target, not host This changes the CFLAGS and related variables passed to compiletest to be passed for the target, not the host, so we can correctly test 32-bit cross compiles on 64-bit host machines. Hopefuly fixes #33379
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 74d1520 with merge f9cd22b... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: retry On Wed, May 4, 2016 at 3:07 AM, bors notifications@github.com wrote:
|
|
@bors: retry |
mk: Pass CFLAGS for target, not host This changes the CFLAGS and related variables passed to compiletest to be passed for the target, not the host, so we can correctly test 32-bit cross compiles on 64-bit host machines. Hopefuly fixes #33379
|
@bors: retry force |
mk: Pass CFLAGS for target, not host This changes the CFLAGS and related variables passed to compiletest to be passed for the target, not the host, so we can correctly test 32-bit cross compiles on 64-bit host machines. Hopefuly fixes #33379
|
💔 Test failed - auto-win-msvc-64-opt |
|
@bors: retry On Wed, May 4, 2016 at 7:32 PM, bors notifications@github.com wrote:
|
This changes the CFLAGS and related variables passed to compiletest to be passed
for the target, not the host, so we can correctly test 32-bit cross compiles on
64-bit host machines.
Hopefuly fixes #33379