Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Ipv4Addr cmp() faster #33891

Merged
merged 1 commit into from May 27, 2016
Merged

Make Ipv4Addr cmp() faster #33891

merged 1 commit into from May 27, 2016

Conversation

polachok
Copy link
Contributor

@polachok polachok commented May 26, 2016 •
edited by apasel422

Closes #33885

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@polachok
Copy link
Contributor Author

My compiler is still building, so I have not tested it ):

@bluss
Copy link
Member

bluss commented May 26, 2016

Thank you!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 26, 2016

📌 Commit 7ba0016 has been approved by bluss

@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label May 26, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 27, 2016
@GuillaumeGomez
Rollup merge of rust-lang#33891 - polachok:faster-ipv4-cmp, r=bluss
ee0821a 
Make Ipv4Addr cmp() faster

Closes rust-lang#33885
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 27, 2016
Merged
bors added a commit that referenced this pull request May 27, 2016
@bors
Auto merge of #33900 - GuillaumeGomez:rollup, r=GuillaumeGomez
ab7c35f 
Rollup of 10 pull requests

- Successful merges: #33753, #33815, #33829, #33858, #33865, #33866, #33870, #33874, #33891, #33898
- Failed merges:
@bors bors merged commit 7ba0016 into rust-lang:master May 27, 2016
@polachok polachok deleted the faster-ipv4-cmp branch May 27, 2016 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@polachok @rust-highfive @bluss @bors @brson