Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add long explanation for E0453, lint attribute overruled by outer forbid #34242

Merged
merged 2 commits into from Jun 13, 2016

Commits on Jun 12, 2016

  1. Configuration menu
    Copy the full SHA
    c17f1a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2016

  1. edit E0453 long explanation for style, clarity, and citizenship

    It turns out that the subsequent lines of the error message comment
    should be aligned like this.
    
    The "turns the corresponding compiler warning" language may not be
    strictly the most accurate—a lint check isn't the same as a compiler
    warning; it emits a compiler warning if it's set to the `warn` level—
    but it may be worth glossing over such distinctions in favor of simple,
    familar phrasings for the sake of pedagogy; thanks to Guillaume Gomez
    for the wording suggestion.
    
    Let's also fix up the introductory clauses of the sentences about how to
    fix the error to put a little more emphasis on the fact that the
    `forbid` setting was probably there for a reason.
    zackmdavis committed Jun 13, 2016
    Configuration menu
    Copy the full SHA
    e4c566c View commit details
    Browse the repository at this point in the history