Book: Small grammatical and stylistic edits to book #34532
Conversation
Also "to access" is cleaner than "for accessing"
grammatical: "Here's" should be "Here are", "rules" is plural.
stylistic: "rules for" is more idiomatic than "rules about".
grammatical: No verb in "One or the other"; changed to "It's one or the other".
code: added implied `fn main() { ... }` because it is referenced in "note: previous borrow ends here"
semantic: "But" seems like the wrong word here, there is now, contrast, only further explanation. "so", "thus" or "therefor" is clearer.
grammatical: Another misuse of "Here's", should be "Here are" (or possibly "Here're").
grammatical: "use" should be capitalized. All other subheadings capitalize the first word.
two terms (input lifetime and output lifetime) so "term" needs to be plural.
no reason for a long comment in a code block when we could take it out, especially since it looks like it's using markdown (`struct`, `&` and `lvl`).
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thank you! It's not super important; one commit per section or one commit for the whole thing is fine. |
| @@ -212,7 +212,7 @@ But, unlike a move, we can still use `v` afterward. This is because an `i32` | |||
| has no pointers to data somewhere else, copying it is a full copy. | |||
|
|
|||
| All primitive types implement the `Copy` trait and their ownership is | |||
| therefore not moved like one would assume, following the ´ownership rules´. | |||
| therefore not moved like one would assume, following the 'ownership rules'. | |||
There was a problem hiding this comment.
we use curly quotes throughout the book
|
Thanks so much for this! A few nits and questions, but great overall 👍 |
|
Thanks, my bad on the curly quotes. I'll fix that. The reason I added the but the code fragment in the book leaves it out: let mut x = 5;
let y = &mut x;
*y += 1;
println!("{}", x);RunI thought it would be clearer if the code fragment had the main function in this case because it is referenced. But obviously this is subjective. |
Ah, I like it! Let's keep that change then 👍 |
|
Ok I think I fixed the quotes. This is how it currently is in the book
compared to different quote:
So I copied that character from the second quote and put it in the markdown, it looks weird in the Github editor though... Update: Looks like the first quotation is using |
|
@bors: r+ rollup looks good to me! |
|
📌 Commit ec66b5a has been approved by |
|
⌛ Testing commit ec66b5a with merge 4177cce... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
@steveklabnik any idea why the build would fail? |
|
@jonmarkprice if @alexcrichton 's comment wasn't clear, this was a failure that was 100% not your fault; a bug in our automation. |
Book: Small grammatical and stylistic edits to book I've been reading [the book](https://doc.rust-lang.org/book/) and noticed a few small grammatical and stylistic issues which I've rolled into this pull request. I'm not sure if I should do so many small, unrelated edits in a single pull request but it seems like a lot of overhead for each small edit. Maybe one commit per edit but one pull request per file/section? Feedback is very much appreciated as this is my first pull request ever! r? @steveklabnik rollup
I've been reading the book and noticed a few small grammatical and stylistic issues which I've rolled into this pull request.
I'm not sure if I should do so many small, unrelated edits in a single pull request but it seems like a lot of overhead for each small edit. Maybe one commit per edit but one pull request per file/section? Feedback is very much appreciated as this is my first pull request ever!
r? @steveklabnik rollup