Various std::process doc improvements.
#34737
Conversation
| @@ -91,7 +96,11 @@ impl IntoInner<imp::Process> for Child { | |||
| fn into_inner(self) -> imp::Process { self.handle } | |||
| } | |||
|
|
|||
| /// A handle to a child process's stdin | |||
| /// A handle to a child process's stdin. This struct is used in the [`stdin`] | |||
There was a problem hiding this comment.
I'm not an english native but I'm pretty sure you don't write "process's" but "process'". But maybe I'm wrong so please correct me if this is the case.
There was a problem hiding this comment.
I would personally say process's, but I might be wrong and English is weird.
|
For such small changes, I think one commit is more than enough. |
frewsxcv
force-pushed
the
libstd-process-child
branch
from
8abf789
to
d0b8114
Compare
|
Squashed. |
|
@bors: r+ rollup |
|
📌 Commit d0b8114 has been approved by |
|
⌛ Testing commit d0b8114 with merge 17964c8... |
|
💔 Test failed - auto-win-gnu-32-opt |
|
Error looks unrelated? |
|
Strange... @bors: retry |
|
⌛ Testing commit d0b8114 with merge e6576bc... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
If anyone has any idea which of my links is broken, let me know. I don't have enough time right now to look into it, but it's not obvious to me which is broken. |
|
It's not clear to me either :/ |
| /// | ||
| /// Calling `wait` (or other functions that wrap around it) will make the | ||
| /// Calling [`wait`] (or other functions that wrap around it) will make the |
There was a problem hiding this comment.
It is this link which is broken.
There was a problem hiding this comment.
How is this link broken?
There was a problem hiding this comment.
Does it think (or other functions that wrap around it) is the href? Is there a way around this if so?
There was a problem hiding this comment.
Yeah that's how markdown is interpreting it, you may be able to escape it via \( I believe
There was a problem hiding this comment.
I just force pushed. Changed it to:
[`wait`][`wait`]
* Link to `process::Command` from `process::Child`. * Move out inline Markdown link in doc comment. * Link to `process::Child::wait` from `process::Child`. * Link to `process::Child` from `process::ChildStdin`. * Link to `process::Child` from `process::ChildStdout`. * Link to `process::Child` from `process::ChildStderr`.
frewsxcv
force-pushed
the
libstd-process-child
branch
from
d0b8114
to
97d96bd
Compare
|
@bors: r+ rollup |
|
📌 Commit 97d96bd has been approved by |
…illaumeGomez Various `std::process` doc improvements. None
No description provided.