Rollup of 13 pull requests #35036

steveklabnik · 2016-07-25T18:46:37Z

Successful merges: Fix ABI string docs in reference.md #34461, Add more docs - mostly warnings - to std::mem::transmute #34609, document DoubleEndedIterator::next_back #34732, doc: add missing pause #34850, Merge guidelines from RFC 1567 into UX Guidelines. #34894, Add HashMap Entry enums examples #34935, Update VecDeque documentation to specify direction of index 0 (#34920) #34974, Update underscore usage (#34903) #34990, Add DirBuilder doc examples #34995, Fix HashMap's values_mut example to use println! #35001, Dir entry doc #35009, Improve Open doc #35010, Remove no_stack_check tests (#34915) #35028
Failed merges:

This is a partial fix for issue rust-lang#34808. Most of the wording was copied verbatim from the RFC. Main difference is that I moved the actual template to the top of the section. It also makes the error explanations the longest section in the guidelines doc for now.

…ang#34920)

Part of fixes for rust-lang#34915

Fix ABI string docs in reference.md

@steveklabnik

…veklabnik Dir entry doc Part of rust-lang#29356. r? @steveklabnik

@steveklabnik

…bnik Improve Open doc Part of rust-lang#29356. r? @steveklabnik

Remove no_stack_check tests (rust-lang#34915) Part of fixes for rust-lang#34915

steveklabnik · 2016-07-25T18:46:44Z

@bors: r+ p=1

bors · 2016-07-25T18:46:45Z

📌 Commit e3e138b has been approved by steveklabnik

rust-highfive · 2016-07-25T18:46:49Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

bors · 2016-07-25T20:51:38Z

⌛ Testing commit e3e138b with merge 8c1bca5...

bors · 2016-07-25T21:02:19Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

arielb1 · 2016-07-25T21:04:21Z

@bors retry

command did not execute successfully: "git" "submodule" "update"
expected success, got: exit code: 1


Unable to find current revision in submodule path 'src/llvm'

bors · 2016-07-25T21:12:05Z

⌛ Testing commit e3e138b with merge c513608...

Rollup of 13 pull requests - Successful merges: #34461, #34609, #34732, #34850, #34894, #34935, #34974, #34990, #34995, #35001, #35009, #35010, #35028 - Failed merges:

bors · 2016-07-25T21:22:57Z

💔 Test failed - auto-win-gnu-32-opt

steveklabnik · 2016-07-25T21:24:11Z

@bors: retry

bors · 2016-07-25T21:27:04Z

⌛ Testing commit e3e138b with merge 8483c2f...

bors · 2016-07-25T21:37:03Z

💔 Test failed - auto-win-gnu-32-opt

alexcrichton · 2016-07-25T22:15:35Z

@bors: retry

On Mon, Jul 25, 2016 at 2:37 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-32-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/5065

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35036 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Iso0ewCnt5YwMwqw_U9WngZVOebks5qZSyCgaJpZM4JUbPA
.

bors · 2016-07-26T09:10:44Z

⌛ Testing commit e3e138b with merge 10a7bc0...

bors · 2016-07-26T09:53:18Z

💔 Test failed - auto-win-msvc-64-cargotest

alexcrichton · 2016-07-26T17:21:00Z

@bors: retry

On Tue, Jul 26, 2016 at 2:53 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-cargotest
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/1279

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35036 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95DOgoiRSfSTLxtpr-ST1-f4wRoMYks5qZdkRgaJpZM4JUbPA
.

bors · 2016-07-26T19:55:15Z

⌛ Testing commit e3e138b with merge 751f2a4...

bors · 2016-07-26T20:51:32Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

alexcrichton · 2016-07-26T20:59:37Z

Ok that seems legitimate.

cc @vadimcn though, the failure to do a backtrace seems worrisome.

vadimcn · 2016-07-26T21:45:14Z

#35014 should fix that

ubsan and others added 30 commits June 24, 2016 15:28

First commit, fix ABI string docs in reference.md

dbe6a09

Add vectorcall and fastcall explanation

1e899fd

Add more docs - mostly warnings - to std::mem::transmute

3d03f75

Fix up some things which scott mentioned

233b45f

Fix some other small nits

6928bbb

More nits :P

2413b52

Add a new alternative

377bbfe

Make sure the documentation compiles

9e94ebf

Fix tests

7ec44e6

Fix nits

8c7668a

Tone it down a little

15a49fe

Fix links, change example to english

451af79

Merge upstream/master: Fix a weird bug

297e396

Hopefully, it now works

7eabff5

document DoubleEndedIterator::next_back

b4ff6b0

fixes rust-lang#34726

Switch around Examples and Alternatives

97003e5

Make it nicer from @alexandermerritt

c0bee60

doc: add missing pause

b0de620

Fix nits

24f8589

Update VecDeque documentation to specify direction of index 0 (rust-l…

0d192c3

…ang#34920)

Add HashMap Entry enums examples

ec33dab

Add DirBuilder doc examples

90bb8d4

Update underscore usage (rust-lang#34903)

6ebe6e8

Fix HashMap's values_mut example to use println!

ccc955c

Add missing links

dad29a6

Add DirEntry doc examples

1669963

Improve Open doc

debb2ac

Remove no_stack_check tests (rust-lang#34915)

96932cf

Part of fixes for rust-lang#34915

Rollup merge of rust-lang#34461 - ubsan:master, r=steveklabnik

48fda61

Fix ABI string docs in reference.md

steveklabnik added 3 commits July 25, 2016 14:46

Rollup merge of rust-lang#35009 - GuillaumeGomez:dir_entry_doc, r=ste…

181d39d

…veklabnik Dir entry doc Part of rust-lang#29356. r? @steveklabnik

Rollup merge of rust-lang#35010 - GuillaumeGomez:file_doc, r=stevekla…

dafbe97

…bnik Improve Open doc Part of rust-lang#29356. r? @steveklabnik

Rollup merge of rust-lang#35028 - abhijeetbhagat:patch-6, r=alexcrichton

e3e138b

Remove no_stack_check tests (rust-lang#34915) Part of fixes for rust-lang#34915

rust-highfive assigned alexcrichton Jul 25, 2016

steveklabnik closed this Jul 26, 2016

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 13 pull requests #35036

Rollup of 13 pull requests #35036

steveklabnik commented Jul 25, 2016

steveklabnik commented Jul 25, 2016

bors commented Jul 25, 2016

rust-highfive commented Jul 25, 2016

bors commented Jul 25, 2016

bors commented Jul 25, 2016

arielb1 commented Jul 25, 2016 •

edited

bors commented Jul 25, 2016

bors commented Jul 25, 2016

steveklabnik commented Jul 25, 2016

bors commented Jul 25, 2016

bors commented Jul 25, 2016

alexcrichton commented Jul 25, 2016

bors commented Jul 26, 2016

bors commented Jul 26, 2016

alexcrichton commented Jul 26, 2016

bors commented Jul 26, 2016

bors commented Jul 26, 2016

alexcrichton commented Jul 26, 2016

vadimcn commented Jul 26, 2016

Rollup of 13 pull requests #35036

Rollup of 13 pull requests #35036

Conversation

steveklabnik commented Jul 25, 2016

steveklabnik commented Jul 25, 2016

bors commented Jul 25, 2016

rust-highfive commented Jul 25, 2016

bors commented Jul 25, 2016

bors commented Jul 25, 2016

arielb1 commented Jul 25, 2016 • edited

bors commented Jul 25, 2016

bors commented Jul 25, 2016

steveklabnik commented Jul 25, 2016

bors commented Jul 25, 2016

bors commented Jul 25, 2016

alexcrichton commented Jul 25, 2016

bors commented Jul 26, 2016

bors commented Jul 26, 2016

alexcrichton commented Jul 26, 2016

bors commented Jul 26, 2016

bors commented Jul 26, 2016

alexcrichton commented Jul 26, 2016

vadimcn commented Jul 26, 2016

arielb1 commented Jul 25, 2016 •

edited