Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor typo in CONTRIBUTING.md #35889

Merged
merged 1 commit into from Aug 23, 2016
Merged

Minor typo in CONTRIBUTING.md #35889

merged 1 commit into from Aug 23, 2016

Conversation

alevy
Copy link
Contributor

@alevy alevy commented Aug 22, 2016

A single missing article

@alevy
Minor type in CONTRIBUTING.md
4b6477f 
A single missing article
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@munyari
Copy link
Contributor

munyari commented Aug 22, 2016 •
edited

Ironically, you have a typo in your commit message/PR title :)

@GuillaumeGomez
Copy link
Member

@munyari: I thought I didn't understand something. 😄

@alevy: Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 22, 2016

📌 Commit 4b6477f has been approved by GuillaumeGomez

@alevy alevy changed the title Minor type in CONTRIBUTING.md Minor typo in CONTRIBUTING.md Aug 22, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Rollup merge of rust-lang#35889 - alevy:patch-1, r=GuillaumeGomez
1e5d804 
Minor type in CONTRIBUTING.md

A single missing article
@sophiajt sophiajt mentioned this pull request Aug 22, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Rollup merge of rust-lang#35889 - alevy:patch-1, r=GuillaumeGomez
766b04e 
Minor type in CONTRIBUTING.md

A single missing article
@sophiajt sophiajt mentioned this pull request Aug 22, 2016
Merged
bors added a commit that referenced this pull request Aug 22, 2016
@bors
Auto merge of #35908 - jonathandturner:rollup, r=jonathandturner
d0da7f6 
Rollup of 20 pull requests

- Successful merges: #35360, #35526, #35809, #35817, #35820, #35824, #35835, #35841, #35842, #35858, #35860, #35861, #35864, #35878, #35879, #35881, #35882, #35889, #35891, #35901
- Failed merges: #35395
@bors bors merged commit 4b6477f into rust-lang:master Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alevy @rust-highfive @munyari @GuillaumeGomez @bors @alexcrichton