#36553 specialisation error 520 is misleading #36652
Conversation
this commit correct E0502 error text. See referenced issue for further info
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
GuillaumeGomez
changed the title
| impl_item.name); | ||
| err.span_label(impl_item.span, &format!("cannot specialize default item `{}`", | ||
| impl_item.name)); | ||
|
|
||
| match tcx.span_of_impl(parent_impl) { | ||
| Ok(span) => { | ||
| err.span_label(span, &"parent `impl` is here"); | ||
| err.note(&format!("to specialize, either the parent `impl` or `{}` \ | ||
| err.note(&format!("to specialize, `{}` \ | ||
| in the parent `impl` must be marked `default`", |
There was a problem hiding this comment.
nit: this string could all fit on one line now.
|
looks good, thanks! r=me with the nit about the string fixed. |
fit string in one line
|
r=nrc |
|
@bors: r+ |
|
📌 Commit 63a5892 has been approved by |
this commit corrects E0520 error text. See referenced issue for further info r? @nrc
this commit corrects E0520 error text.
See referenced issue for further info
r? @nrc