Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[std::io::Chain] Mark first as done only when reading into non-zero length buffer. #36777

Merged
merged 1 commit into from Sep 28, 2016
Merged

[std::io::Chain] Mark first as done only when reading into non-zero length buffer. #36777

merged 1 commit into from Sep 28, 2016

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2016

Fixes #36771.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Sep 27, 2016

📌 Commit 26f9949 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 28, 2016

⌛ Testing commit 26f9949 with merge 5efe513...

@bors
Copy link
Contributor

bors commented Sep 28, 2016

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Sep 27, 2016 at 7:42 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-64-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/5723

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#36777 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Dg4svg_VthNou6G3rk4ka7mFe4Rks5qudP4gaJpZM4KIA-r
.

@bors
Copy link
Contributor

bors commented Sep 28, 2016

⌛ Testing commit 26f9949 with merge 4f79716...

bors added a commit that referenced this pull request Sep 28, 2016
@bors
Auto merge of #36777 - tmiasko:chain-read-eof, r=alexcrichton
4f79716 
[std::io::Chain] Mark first as done only when reading into non-zero length buffer.

Fixes #36771.
@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 28, 2016
@bors
Copy link
Contributor

bors commented Sep 28, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing 4f79716 to master...

@bors bors merged commit 26f9949 into rust-lang:master Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rust-highfive @alexcrichton @bors @bluss @tmiasko