Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net examples #37806

Merged
merged 2 commits into from Nov 17, 2016
Merged

Net examples #37806

merged 2 commits into from Nov 17, 2016
+144 −6

Conversation

GuillaumeGomez
Copy link
Member

frewsxcv
frewsxcv reviewed Nov 16, 2016
View reviewed changes
src/libstd/net/ip.rs
/// [ip7][http://man7.org/linux/man-pages/man7/ip.7.html]
/// W. Richard Stevens, p. 891; see also [ip7].
///
/// [ip7]: (http://man7.org/linux/man-pages/man7/ip.7.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this URL be in parenthesis?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it shouldn't.

@steveklabnik
Copy link
Member

@bors: delegate=frewsxcv

@bors
Copy link
Contributor

bors commented Nov 16, 2016

✌️ @frewsxcv can now approve this pull request

@frewsxcv
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 17, 2016

📌 Commit 976bfc0 has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 17, 2016
@GuillaumeGomez
Rollup merge of rust-lang#37806 - GuillaumeGomez:net_examples, r=frew…
6bdb9d1 
…sxcv

Net examples

r? @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 17, 2016
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 17, 2016
@GuillaumeGomez
Rollup merge of rust-lang#37806 - GuillaumeGomez:net_examples, r=frew…
214bcc5 
…sxcv

Net examples

r? @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 17, 2016
Merged
bors added a commit that referenced this pull request Nov 17, 2016
@bors
Auto merge of #37837 - GuillaumeGomez:rollup, r=GuillaumeGomez
89386d6 
Rollup of 8 pull requests

- Successful merges: #37752, #37757, #37759, #37766, #37772, #37799, #37806, #37821
- Failed merges: #37442
@bors bors merged commit 976bfc0 into rust-lang:master Nov 17, 2016
@GuillaumeGomez GuillaumeGomez deleted the net_examples branch November 18, 2016 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv left review comments

Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GuillaumeGomez @steveklabnik @bors @frewsxcv