Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

note individual lint name in messages set via lint group attribute #38103

Merged
merged 4 commits into from Feb 5, 2017
Merged

note individual lint name in messages set via lint group attribute #38103

merged 4 commits into from Feb 5, 2017

Commits on Feb 4, 2017

  1. note individual lint name set via lint group attribute in notes 

    Warning or error messages set via a lint group attribute
(e.g. `#[deny(warnings)]`) should still make it clear which individual
lint (by name) was triggered, similarly to how we include "on by
default" language for default lints. This—and, while we're here, the
existing "on by default" language—can be tucked into a note rather than
cluttering the main error message. This occasions the slightest of
refactorings (we now have to get the diagnostic-builder with the main
message first, before matching on the lint source).

This is in the matter of rust-lang#36846.
    @zackmdavis
    zackmdavis committed Feb 4, 2017
    Configuration menu
    Copy the full SHA
    65b0554 View commit details
    Browse the repository at this point in the history

  2. note lint group set on command line triggering individual lint 

    Previously, the note/message for the source of a lint being the command
line unconditionally named the individual lint, even if the actual
command specified a lint group (e.g., `-D warnings`); here, we take note
of the actual command options so we can be more specific.

This remains in the matter of rust-lang#36846.
    @zackmdavis
    zackmdavis committed Feb 4, 2017
    Configuration menu
    Copy the full SHA
    9301446 View commit details
    Browse the repository at this point in the history

  3. make lint-group-style test a UI rather than a compile-fail test 

    As suggested by Niko Matsakis in review
(rust-lang#38103 (comment)) regarding
the endeavor prompted by rust-lang#36846.
    @zackmdavis
    zackmdavis committed Feb 4, 2017
    Configuration menu
    Copy the full SHA
    778958f View commit details
    Browse the repository at this point in the history

  4. note wording: lint implied by lint group, not lint group implies lint

    @zackmdavis
    zackmdavis committed Feb 4, 2017
    Configuration menu
    Copy the full SHA
    72af42e View commit details
    Browse the repository at this point in the history