Implement RFC #1725 (read_unaligned, write_unaligned) #38309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
force-pushed
the
rfc-1725
branch
3 times, most recently
from
70726f3
to
3fa0724
Compare
bluss
reviewed
Dec 12, 2016
| copy_nonoverlapping(&src as *const T as *const u8, | ||
| dst as *mut u8, | ||
| mem::size_of::<T>()); | ||
| } |
There was a problem hiding this comment.
This consumes src and must forget src here. This calls for a test!
There was a problem hiding this comment.
lol, the RFC forgot to even talk about ownership semantics. Following how ptr::write works is the obvious thing.
There was a problem hiding this comment.
Fixed and added a test.
bluss
changed the title
|
(I was just chasing another PR that didn't have anything recognizable in the name.. so I took the liberty of adding to the name here.) |
|
@bors r=alexcrichton |
|
📌 Commit 75fe727 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 13, 2016
Implement RFC #1725 (read_unaligned, write_unaligned) cc #37955 r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #37955
r? @alexcrichton