Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Fix short summaries in search results #38330

Merged
merged 1 commit into from Dec 23, 2016

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Dec 12, 2016

They should be run through a Markdown renderer in rustdoc to remove
links.

This also fixes the mouse over text for the Crates list on the sidebar.

before after

They should be run through a Markdown renderer in rustdoc to remove
links.

This also fixes the mouse over text for the Crates list on the sidebar.
@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member

What was the issue on the sidebar? I don't see any difference between the two versions.

@GuillaumeGomez
Copy link
Member

Ah never mind, didn't see the hover text.

@steveklabnik
Copy link
Member

Travis failure was spurious. Thanks!

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 22, 2016

📌 Commit 4f15e11 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Dec 22, 2016

⌛ Testing commit 4f15e11 with merge a173778...

bors added a commit that referenced this pull request Dec 22, 2016
rustdoc: Fix short summaries in search results

They should be run through a Markdown renderer in rustdoc to remove
links.

This also fixes the mouse over text for the Crates list on the sidebar.

[before](https://doc.rust-lang.org/nightly/std/index.html?search=ord) [after](https://ollie27.github.io/rust_doc_test/std/index.html?search=ord)
@bors bors merged commit 4f15e11 into rust-lang:master Dec 23, 2016
@ollie27 ollie27 deleted the rustdoc_short_summaries branch December 24, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants